fix: adding typing delay to associated users table #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 84.33% 84.90% +0.57%
==========================================
Files 185 185
Lines 3855 3856 +1
Branches 954 945 -9
==========================================
+ Hits 3251 3274 +23
+ Misses 581 564 -17
+ Partials 23 18 -5 ☔ View full report in Codecov by Sentry. |
marlonkeating
suggested changes
Jan 22, 2025
marlonkeating
left a comment
marlonkeating
left a comment
There was a problem hiding this comment.
Can we add a unit test to EnterpriseCustomerUsersTable.test.jsx?
|
|
||
| if (enterpriseUuid) { | ||
| fetch(); | ||
| if (args.filters.length && args.filters[0].value.length > 2) { |
There was a problem hiding this comment.
[question] Do we know that the typing filter will always be first in the list of filters?
Contributor
Author
There was a problem hiding this comment.
Yes, its the only filter we have for this table
src/Configuration/Customers/data/hooks/useCustomerUsersTableData.js
Outdated
Show resolved
Hide resolved
kiram15
force-pushed
the
kiram15/ENT-9554
branch
from
f4300ce to
f06d55b
Compare
marlonkeating
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Screen.Recording.2025-01-21.at.4.13.13.PM.mov